Skip to content

feat: NGINXaaS - Certificate Fetch via Private Endpoint support #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

feat: NGINXaaS - Certificate Fetch via Private Endpoint support #1137

merged 1 commit into from
Sep 26, 2025

Conversation

arpith-f5
Copy link
Contributor

@arpith-f5 arpith-f5 commented Sep 17, 2025 •
edited
Loading

This commit updates the NGINXaaS documentation to add instructions for fetching certificates via private endpoints.

Proposed changes

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩

@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginxaas-azure Issues related to NGINX as a Service for Azure labels Sep 17, 2025
mjang
mjang reviewed Sep 18, 2025
View reviewed changes
@arpith-f5 arpith-f5 self-assigned this Sep 23, 2025
@arpith-f5 arpith-f5 marked this pull request as ready for review September 23, 2025 17:33
@arpith-f5 arpith-f5 requested review from a team as code owners September 23, 2025 17:33
russokj
russokj approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@russokj russokj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

ryepup
ryepup reviewed Sep 26, 2025
View reviewed changes
mjang
mjang approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed a minor style guide issue. Approving with one comment.

@arpith-f5
feat: NGINXaaS - Certificate Fetch via Private Endpoint support
99ee4a4 
This commit updates the NGINXaaS documentation to add instructions for fetching certificates via private endpoints.
@arpith-f5 arpith-f5 merged commit 7cb4d33 into nginx:main Sep 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryepup ryepup ryepup left review comments

@mjang mjang mjang approved these changes

@russokj russokj russokj approved these changes

Assignees

@arpith-f5 arpith-f5

Labels
documentation Improvements or additions to documentation product/nginxaas-azure Issues related to NGINX as a Service for Azure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arpith-f5 @ryepup @mjang @russokj